New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Mend #406

Merged
merged 3 commits into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@rumblefrog
Copy link
Member

rumblefrog commented Mar 5, 2018

Description

During VerifyBan callback, if banned, it will fetch the ban record's IP column. If the column is empty, it will execute another query to mend(fill) it in.

Motivation and Context

Closes #187

How Has This Been Tested?

Tested with the latest ip-mend commit with a clean installation on the sourcemod 1.8.6041

Screenshots (if appropriate):

ip-mend-before
ip-mend-after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

rumblefrog added some commits Mar 5, 2018

@rumblefrog rumblefrog self-assigned this Mar 5, 2018

@rumblefrog rumblefrog requested a review from Groruk Mar 5, 2018

@CrazyHackGUT

This comment has been minimized.

Copy link
Contributor

CrazyHackGUT commented Mar 5, 2018

I think this is a bad idea: to mix the code with obsolete (old) syntax and new one.

@Groruk

Groruk approved these changes Mar 5, 2018

@Groruk

This comment has been minimized.

Copy link
Member

Groruk commented Mar 5, 2018

I think this is a bad idea: to mix the code with obsolete (old) syntax and new one.

To be honest the plugin will need a complete overhaul at some point in the future anyway and the code cant really be more messy than it already is, so mixing syntax should be fine for now.

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Mar 5, 2018

I think this is a bad idea: to mix the code with obsolete (old) syntax and new one.

You would be right, but I plan to migrate the old syntax to the new ones slowly. This PR will be the start of a gradual migration I suppose

@CrazyHackGUT

This comment has been minimized.

Copy link
Contributor

CrazyHackGUT commented Mar 5, 2018

I plan to migrate the old syntax to the new ones slowly

Oh, nice.
You don't plan add the ban feature for the disconnected players?

@rumblefrog

This comment has been minimized.

Copy link
Member

rumblefrog commented Mar 5, 2018

You don't plan add the ban feature for the disconnected players?

Features will always come after the fixes; but if someone makes an issue on it, I'll look into it

@rumblefrog rumblefrog merged commit 13f8961 into v1.x Mar 8, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rumblefrog rumblefrog deleted the ip-mend branch Mar 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment