New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Fork Namespace #415

Merged
merged 2 commits into from Mar 12, 2018

Conversation

Projects
None yet
2 participants
@rumblefrog
Copy link
Member

rumblefrog commented Mar 11, 2018

Description

To avoid a collision with the official SourceBans, native namespace would have to be changed to be unique from the official.

Motivation and Context

Closes #414

https://forums.alliedmods.net/showpost.php?p=2582592&postcount=1222

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

rumblefrog added some commits Mar 11, 2018

@Groruk

Groruk approved these changes Mar 12, 2018

@rumblefrog rumblefrog merged commit 8c1e276 into v1.x Mar 12, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@rumblefrog rumblefrog deleted the fork-namespace branch Mar 12, 2018

DarkDeviL added a commit to DarkServ/sourcebans-pp that referenced this pull request Mar 26, 2018

@DarkDeviL DarkDeviL referenced this pull request Mar 26, 2018

Merged

Renaming leftovers from #414 and #415 #429

3 of 7 tasks complete

rumblefrog added a commit that referenced this pull request Mar 26, 2018

Merge pull request #429 from DarkServ/v1.x
Renaming leftovers from #414 and #415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment