Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RCON connectivity from CServerRcon to SourceQuery #612

Merged
merged 29 commits into from Oct 12, 2019

Conversation

@Groruk
Copy link
Member

commented Sep 28, 2019

Description

Finally migrate RCON connectivity from CServerRcon to SourceQuery.
Also update the Status parser regex.

Fixes #474
Fixes #610

How Has This Been Tested?

Tests:

  • Test Status regex in multiple games (tf2, csgo, css, etc.)
  • KickPlayer() in admin.kickit.php
  • BlockPlayer() in admin.blockit.php
  • checkMultiplePlayers()
  • PasteBlock()
  • SendMessage()
  • ViewCommunityProfile()
  • RehashAdmins()
  • SendRcon()
  • KickPlayer()

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
Groruk added 15 commits Sep 28, 2019
flight framework goes unused in 1.7.0
Currently all $_GET and $_POST data gets filtered with FILTER_SANITIZE_STRING, to combat this in player name checks we now filter both names before comparing them. (Should fix #610)
Groruk added 10 commits Oct 1, 2019
@Groruk Groruk marked this pull request as ready for review Oct 9, 2019
Groruk added 3 commits Oct 9, 2019
@Groruk Groruk requested a review from rumblefrog Oct 9, 2019
@Groruk Groruk changed the title [WIP] Migrate RCON connectivity from CServerRcon to SourceQuery Migrate RCON connectivity from CServerRcon to SourceQuery Oct 9, 2019
Copy link
Member

left a comment

Code looks excellent from a glance; however, I won't be able to test this until Friday.

@Groruk Groruk merged commit de2444b into sbpp:v1.x Oct 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Groruk Groruk deleted the Groruk:rcon-migration branch Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.