Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pepperminty Wiki login cookie #200

Closed
sbrl opened this issue Jul 28, 2020 · 1 comment
Closed

Fix Pepperminty Wiki login cookie #200

sbrl opened this issue Jul 28, 2020 · 1 comment
Labels
Area: Code It's got something to do with code

Comments

@sbrl
Copy link
Owner

sbrl commented Jul 28, 2020

Pepperminty Wiki uses a cookie to record when a user is logged in. This is normal, but apparently the behaviour of cookies is changing soon. See this error message from Firefox 79.0b9:

Cookie “PHPSESSID” will be soon rejected because it has the “sameSite” attribute set to “none” or an invalid value, without the “secure” attribute. To learn more about the “sameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite
@sbrl sbrl added the Area: Code It's got something to do with code label Jul 28, 2020
@sbrl
Copy link
Owner Author

sbrl commented Jul 28, 2020

Uh-oh - it looks like only PHP 7.3+ supports setting the SameSite cookie flag with setcookie(). We've implemented a warning message via error_log() for users of PHP 7.2 and below.

Anyway, this issue is now fixed and will be released in v0.22.

@sbrl sbrl closed this as completed Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code It's got something to do with code
Projects
None yet
Development

No branches or pull requests

1 participant