Skip to content

Fix compromise detection #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Fix compromise detection #179

merged 2 commits into from
Jan 10, 2020

Conversation

nivex
Copy link
Contributor

@nivex nivex commented Jan 9, 2020

Compromise detection has inverted logic handling response_code and did not honor the settingsFilename variable.

Compromise detection has inverted logic handling response_code and did not honor the settingsFilename variable.
@nethope
Copy link

nethope commented Jan 9, 2020

On a relatively new Linode running Ubuntu bionic, I couldn't get Pepperminty Wiki past Error: peppermint.json.compromised exists on disk, so it's likely you need to block access to 'peppermint.json' from the internet. If you've done this already, please delete peppermint.json.compromised and reload this page. despite blocking access to peppermint.json (curl got 403). Changing the logic from OR to AND got me past the first run checks.

Copy link
Owner

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks @nivex! Great spot. I'll merge this and do a point release.

I tweaked the formatting of your code a bit too.

@sbrl sbrl merged commit 27a7349 into sbrl:master Jan 10, 2020
@nivex nivex deleted the patch-1 branch January 10, 2020 17:09
sbrl added a commit that referenced this pull request Jan 10, 2020
sbrl added a commit that referenced this pull request Jan 10, 2020
@sbrl
Copy link
Owner

sbrl commented Jan 10, 2020

Released v0.20.1-hotfix1: https://github.com/sbrl/Pepperminty-Wiki/releases/tag/v0.20.1-hotfix1

Thanks @nivex and @nethope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants