New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change PathFinder#get to get() #104

Merged
merged 2 commits into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@dwijnand
Member

dwijnand commented Dec 15, 2017

Given it side-effects by looking at the FS it should have parens.

With regards to source compatibility fortunately going in this direction
is safe.

Fixes #36

@@ -375,7 +375,7 @@ sealed abstract class PathFinder {
* The files returned by this method will reflect the underlying filesystem at the time of calling.
* If the filesystem changes, two calls to this method might be different.
*/
final def get: Seq[File] = {
final def get(): Seq[File] = {

This comment has been minimized.

@eed3si9n

eed3si9n Dec 15, 2017

Member

Are we adding empty parentheses because it forces evaluation?

This comment has been minimized.

@eed3si9n

eed3si9n Dec 15, 2017

Member

Would this logic apply to getURLs?

This comment has been minimized.

@dwijnand

dwijnand Dec 15, 2017

Member

Yes to both. I'll look at the uses of get and see if there are more to add.

dwijnand added some commits Dec 15, 2017

Change PathFinder#get to get()
Given it side-effects by looking at the FS it should have parens.

With regards to source compatibility fortunately going in this direction
is safe.

Fixes #36

@eed3si9n eed3si9n merged commit 844bfa6 into sbt:1.x Dec 19, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Dec 19, 2017

@dwijnand dwijnand deleted the dwijnand:add-parens-to-PathFinder-get branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment