Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ERROR_PATH_NOT_FOUND to FileNotFoundException in WinMilli #120

Merged
merged 1 commit into from Jan 12, 2018

Conversation

Projects
None yet
2 participants
@cunei
Copy link
Contributor

commented Jan 12, 2018

Windows has two different error codes for files that do not exist:
ERROR_FILE_NOT_FOUND and ERROR_PATH_NOT_FOUND. We must catch both.

Fixes sbt/sbt#3871

Convert ERROR_PATH_NOT_FOUND to FileNotFoundException in WinMilli
Windows has two different error codes for files that do not exist:
ERROR_FILE_NOT_FOUND and ERROR_PATH_NOT_FOUND. We must catch both.

@cunei cunei requested review from eed3si9n and dwijnand Jan 12, 2018

@dwijnand
Copy link
Member

left a comment

LGTM. Thanks for the details insight (in sbt/sbt#3871).

@cunei cunei merged commit 1dbb37f into sbt:1.1.x Jan 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cunei cunei deleted the cunei:wip-fix-3871 branch Jan 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.