New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinMilli: enable read/read/delete/rename sharing #134

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
3 participants
@cunei
Contributor

cunei commented Feb 26, 2018

In Windows, reading or writing file attributes requires opening
the file via CreateFile(). If only FILE_SHARE_READ is specified
when reading the timestamp, the CreateFile() call will fail
when the file happens to be already open for writing. This
pull request specifies that the file that is being opened has
shared read and write access; the shared delete mode (which also
implies rename) is also allowed, and in case the subsequent
timestamp get/set fails (if the file disappears) the usual
exception-to-zero code path will be taken.

See sbt/sbt#3972

WinMilli: enable read/read/delete/rename sharing
In Windows, reading or writing file attributes requires opening
the file via CreateFile(). If only FILE_SHARE_READ is specified
when reading the timestamp, the CreateFile() call will fail
when the file happens to be already open for writing. This
pull request specifies that the file that is being opened has
shared read and write access; the shared delete mode (which also
implies rename) is also allowed, and in case the subsequent
timestamp get/set fails (if the file disappears) the usual
exception-to-zero code path will be taken.

See sbt/sbt#3972

@cunei cunei added the in progress label Feb 26, 2018

@cunei

This comment has been minimized.

Contributor

cunei commented Feb 26, 2018

Please do not merge yet

@typesafe-tools

This comment has been minimized.

typesafe-tools commented Feb 26, 2018

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.1.x sbt/sbt@9a5b7bc
zinc 1.1.x sbt/zinc@ef5b5fc
io pull/134/head 6aba8ca
librarymanagement 1.1.x sbt/librarymanagement@69fb352
util 1.1.x sbt/util@9f12566
website 1.1.x

The result is: SUCCESS

The binaries are at https://dl.bintray.com/sbt/maven-snapshots
The new sbt version is: 1.1.2-bin-20180226T135405
(restart)

@cunei cunei requested review from eed3si9n and dwijnand Mar 6, 2018

@cunei

This comment has been minimized.

Contributor

cunei commented Mar 6, 2018

I ran more tests, and all seems to work. I would merge it in, preferably in some branch that will have an RC. Please review and merge if things look ok.

@dwijnand dwijnand changed the base branch from 1.1.x to 1.x Mar 7, 2018

@dwijnand

This comment has been minimized.

Member

dwijnand commented Mar 7, 2018

I would merge it in, preferably in some branch that will have an RC.

re-targeted to 1.x then

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 7, 2018

@dwijnand dwijnand merged commit cc3e533 into 1.x Mar 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dwijnand dwijnand deleted the wip-3972 branch Mar 7, 2018

@dwijnand dwijnand removed the in progress label Mar 7, 2018

@cunei cunei referenced this pull request Jun 7, 2018

Closed

Appveyor #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment