Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null WatchEvent context #140

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
3 participants
@oneill
Copy link
Contributor

commented Apr 6, 2018

WatchEvent.context() can return null for OVERFLOW events (https://docs.oracle.com/javase/8/docs/api/java/nio/file/StandardWatchEventKinds.html#OVERFLOW).
The context was treated as a valid path, even when it was null. This commit prevents a NullPointerException from being thrown in this case.

Fixes #112

Handle null WatchEvent context
WatchEvent.context() can return null for OVERFLOW events (https://docs.oracle.com/javase/8/docs/api/java/nio/file/StandardWatchEventKinds.html#OVERFLOW).
The context was treated as a valid path, even when it was null. This commit prevents a NullPointerException from being thrown in this case.

Fixes #112

@eed3si9n eed3si9n added the ready label Apr 6, 2018

@eed3si9n
Copy link
Member

left a comment

Thanks!

@eed3si9n eed3si9n merged commit 471cf7b into sbt:1.1.x Apr 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the ready label Apr 7, 2018

@dwijnand dwijnand modified the milestones: 1.1.6, 1.1.7 Apr 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.