Join GitHub today
Watch improvements #142
This pull request makes some improvements to the source modification watch.
referenced this pull request
Apr 12, 2018
2 times, most recently
Apr 13, 2018
dwijnand left a comment
despite its size reviewing this was a real pleasure commit-by-commit.. until the last commit bomb :)
I don't have the bandwidth to review it in detail, but I like the sound of it.
I'll give Eugene a chance to weigh in in case he weighs in differently to me.
I figured out the travis issues with PollingWatchServiceSpec (among other things, the travis osx agents use HFS+, which doesn't have millisecond precision). I also added the scaladocs to EventMonitor as requested. Finally, I renamed