Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated *ModifiedTime methods #154

Merged

Conversation

Projects
None yet
3 participants
@dwestheide
Copy link
Contributor

commented May 15, 2018

This PR removes calls to the deprecated methods setModifiedTime and getModifiedTime, maintaining the previous behaviour.

Remove use of deprecated *ModifiedTime methods
Replaces call to setModifiedTime with setModifiedTimeOrFalse
and getModifiedTime with Milli.getModifiedTime.
@typesafe-tools

This comment has been minimized.

Copy link

commented May 15, 2018

A validation involving this pull request is in progress...

@dwijnand
Copy link
Member

left a comment

LGTM! Thanks.

@typesafe-tools

This comment has been minimized.

Copy link

commented May 15, 2018

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.1.x sbt/sbt@f6fa7cb
zinc 1.1.x sbt/zinc@899d7bd
io pull/154/head aa1b48e
librarymanagement 1.1.x sbt/librarymanagement@10b6efc
util 1.1.x sbt/util@d40517b
website 1.1.x

The result is: FAILED
(restart)

@typesafe-tools

This comment has been minimized.

Copy link

commented May 19, 2018

A validation involving this pull request is in progress...

@typesafe-tools

This comment has been minimized.

Copy link

commented May 19, 2018

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.1.x sbt/sbt@250874d
zinc 1.1.x sbt/zinc@899d7bd
io pull/154/head aa1b48e
librarymanagement 1.1.x sbt/librarymanagement@7eb2598
util 1.1.x sbt/util@d40517b
website 1.1.x

The result is: FAILED
(restart)

@dwijnand

This comment has been minimized.

Copy link
Member

commented May 23, 2018

The validator just suffered sbt/sbt#4148. Let's try again? :-/

@typesafe-tools

This comment has been minimized.

Copy link

commented May 23, 2018

A validation involving this pull request is in progress...

@typesafe-tools

This comment has been minimized.

Copy link

commented May 23, 2018

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.1.x sbt/sbt@250874d
zinc 1.1.x sbt/zinc@899d7bd
io pull/154/head aa1b48e
librarymanagement 1.1.x sbt/librarymanagement@7eb2598
util 1.1.x sbt/util@d40517b
website 1.1.x

The result is: SUCCESS
(restart)

@dwijnand dwijnand added this to the 1.1.9 milestone May 23, 2018

@dwijnand dwijnand merged commit 0b1c1b0 into sbt:1.1.x May 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.