New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper methods to create mappings #38

Merged
merged 6 commits into from Mar 28, 2017

Conversation

Projects
None yet
3 participants
@muuki88
Contributor

muuki88 commented Mar 2, 2017

  • directory: create mappings from a baseDirectory including the baseDirectory
  • contentOf: create mappings from a baseDirectory excluding the baseDirectory

I put this on the Path object. Not sure if this is a good place.
The test aren't property based. I probably need to add some corner cases like

  • empty baseDirectory
  • if baseDirectory is a file
  • non-existing baseDirectory
Add helper methods to create mappings
- directory: create mappings from a baseDirectory including the baseDirectory
- contentOf: create mappings from a baseDirectory excluding the baseDirectory

@eed3si9n eed3si9n added the ready label Mar 2, 2017

@dwijnand

I've a few comments, but also I think this should probably live with its brothers in Mapper (PathMapper.scala).

Thank you for taking the time to PR!

Show outdated Hide outdated io/src/main/scala/sbt/io/Path.scala Outdated
Show outdated Hide outdated io/src/main/scala/sbt/io/Path.scala Outdated
Show outdated Hide outdated io/src/main/scala/sbt/io/Path.scala Outdated
@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Mar 18, 2017

Member

@dwijnand What's the status on this PR?

Member

eed3si9n commented Mar 18, 2017

@dwijnand What's the status on this PR?

Show outdated Hide outdated io/src/main/scala/sbt/io/PathMapper.scala Outdated
Show outdated Hide outdated io/src/main/scala/sbt/io/PathMapper.scala Outdated
Show outdated Hide outdated io/src/main/scala/sbt/io/PathMapper.scala Outdated
@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Mar 18, 2017

Member

I just submitted the review that I had pending from 2 weeks ago..

Haven't reviewed the latest 2 commits.

Member

dwijnand commented Mar 18, 2017

I just submitted the review that I had pending from 2 weeks ago..

Haven't reviewed the latest 2 commits.

@muuki88

This comment has been minimized.

Show comment
Hide comment
@muuki88

muuki88 Mar 24, 2017

Contributor

Sorry for the long standing PR. Finally got time to clean this up

Contributor

muuki88 commented Mar 24, 2017

Sorry for the long standing PR. Finally got time to clean this up

@dwijnand dwijnand self-assigned this Mar 27, 2017

@dwijnand

Thanks Muki!

@dwijnand dwijnand merged commit 47725b5 into sbt:1.0 Mar 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Mar 28, 2017

@muuki88 muuki88 deleted the muuki88:add-mapping-helpers branch Mar 28, 2017

@dwijnand dwijnand removed their assignment Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment