New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent concurrent modification of keysWithEvents map #90

Merged
merged 2 commits into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@dwijnand
Member

dwijnand commented Nov 29, 2017

Fixup and rebase of @mechkg's #89.

Fixes #86
which means
Fixes sbt/sbt#3687
Fixes sbt/sbt#3695
Fixes sbt/sbt#3775

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 29, 2017

Member
[info] PollingWatchServiceSpec:
[info] - should detect modified files *** FAILED ***
[info]   false was not equal to true (SourceModificationWatchSpec.scala:322)

Should we be worried?

Member

eed3si9n commented Nov 29, 2017

[info] PollingWatchServiceSpec:
[info] - should detect modified files *** FAILED ***
[info]   false was not equal to true (SourceModificationWatchSpec.scala:322)

Should we be worried?

mechkg and others added some commits Nov 29, 2017

Really make "should detect modified files" pending
I don't understand how you're meant to do pendingUntilFixed in ScalaTest, like specs2..

@dwijnand dwijnand requested a review from eed3si9n Dec 1, 2017

@dwijnand dwijnand merged commit 4c3d042 into sbt:1.0.x Dec 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand deleted the dwijnand:fix-PollingWatchKey.pollEvents branch Dec 1, 2017

@dwijnand dwijnand removed the in progress label Dec 1, 2017

}
// watchTest(parentDir)(pollDelay, maxWait) {
// IO.write(file, "bar")
// }
pending // until fixed https://github.com/sbt/io/issues/82

This comment has been minimized.

@ches

ches Dec 29, 2017

You wrap it as a block I think 😊

pendingUntilFixed {
  watchTest(parentDir)(pollDelay, maxWait) {
    IO.write(file, "bar")
  }
}
@ches

ches Dec 29, 2017

You wrap it as a block I think 😊

pendingUntilFixed {
  watchTest(parentDir)(pollDelay, maxWait) {
    IO.write(file, "bar")
  }
}

This comment has been minimized.

@dwijnand

dwijnand Dec 30, 2017

Member

Ah! Cheers.

@dwijnand

dwijnand Dec 30, 2017

Member

Ah! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment