Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #180 to handle null contentType #214

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
4 participants
@staale
Copy link
Contributor

commented Feb 23, 2018

Fixes #180

If the content type is null, the call for .toString on it will cause an NPE. This fixes this issue by wrapping the call in an Option, then mapping toString or falling back to null. getCharSetFromContentType handles null by returning ISO-8859-1

Fix to issue #180 to handle null contentType
If the content type is null, the call for .toString on it will cause an NPE. This fixes this issue by wrapping the call in an Option, then mapping toString or falling back to null. getCharSetFromContentType handles null by returning ISO-8859-1

@eed3si9n eed3si9n added the ready label Feb 23, 2018

@typesafe-tools

This comment has been minimized.

Copy link

commented Feb 24, 2018

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.1.x sbt/sbt@9a5b7bc
zinc 1.1.x sbt/zinc@ef5b5fc
io 1.1.x sbt/io@13eb241
librarymanagement pull/214/head 42e23e5
util 1.1.x sbt/util@9f12566
website 1.1.x

The result is: SUCCESS
(restart)

@dwijnand
Copy link
Member

left a comment

lgtm. @eed3si9n, wdyt?

@dwijnand dwijnand requested a review from eed3si9n Feb 26, 2018

@eed3si9n
Copy link
Member

left a comment

Thanks for the contribution!
This is great.

@dwijnand dwijnand merged commit 1a566d8 into sbt:1.1.x Feb 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Feb 28, 2018

@staale staale deleted the staale:patch-1 branch Feb 28, 2018

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.