Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sbt to specify -Dconfig.resource=/path/to/configFile without disabling gigahorse #241

Merged

Conversation

Projects
None yet
3 participants
@tanishiking
Copy link
Contributor

commented May 17, 2018

This PR fixes sbt/sbt#3585.

concerns

  • Actually we were able to configure gigahorse inside sbt by -Dconfig.file=/path/to/configFile (but I don't think anyone deliberately configure gigahorse in sbt by -Dconfig.file) , this PR disable sbt user to configure gigahorse in sbt.
    • Maybe we should add any ways to configure gigahorse in sbt? (like -Dsbt.gigahorse.config=/path/to/conf/for/gigahorse
Enable sbt to specify config.resource without disabling gigahorse
Fix sbt/sbt#3585.
Gigahorse.config tries to load specified config file in sbt's classpath
and of course fail to find the specified config file, and throw
java.io.IOException if we specify config.resource, because

We can avoid trying to load specified config file inside sbt by
avoid using Gigahorse.config that call `ConfigFactory.load()` inside.

This commit fixes librarymanagement not to use Gigahorse.config and make
it use gigahorse.Config() which returns gigahorse's default config
without calling `ConfigFactory.load()` instead.
@dwijnand

This comment has been minimized.

Copy link
Member

commented May 17, 2018

Cool! Thank you for this @tanishiking!

Requesting a review by Eugene, but to me this looks good to go.

@dwijnand dwijnand requested a review from eed3si9n May 17, 2018

@eed3si9n
Copy link
Member

left a comment

Nice. Thank you @tanishiking!

@eed3si9n eed3si9n merged commit 7eb2598 into sbt:1.1.x May 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.