New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no git tags, can't load project with `useGitDescribe := true` #89

Closed
aryairani opened this Issue Jun 10, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@aryairani

aryairani commented Jun 10, 2015

Would it be ok to have a fallback version, like when useGitDescribe := false?

fernandomora added a commit to fernandomora/sbt-git that referenced this issue Jun 20, 2015

fernandomora added a commit to fernandomora/sbt-git that referenced this issue Jun 20, 2015

fernandomora added a commit to fernandomora/sbt-git that referenced this issue Jun 21, 2015

@jeantil jeantil referenced this issue Jul 15, 2015

Merged

fix for #67 #88

@jsuereth

This comment has been minimized.

Show comment
Hide comment
@jsuereth

jsuereth Jul 17, 2015

Member

Yes. PR welcome.

Member

jsuereth commented Jul 17, 2015

Yes. PR welcome.

@2m 2m referenced this issue Jul 26, 2015

Merged

Publish to bintray #6

@2m

This comment has been minimized.

Show comment
Hide comment
@2m

2m Jul 26, 2015

Member

Hey, @fernandomora are you planning to provide a PR to fix this issue? :)

Member

2m commented Jul 26, 2015

Hey, @fernandomora are you planning to provide a PR to fix this issue? :)

@fernandomora

This comment has been minimized.

Show comment
Hide comment
@fernandomora

fernandomora Jul 26, 2015

Contributor

@2m As far as I know this bug was fixed and merged in PR #88 and later refactored and merged in PR #94, but it still han't been released

Contributor

fernandomora commented Jul 26, 2015

@2m As far as I know this bug was fixed and merged in PR #88 and later refactored and merged in PR #94, but it still han't been released

@2m

This comment has been minimized.

Show comment
Hide comment
@2m

2m Jul 27, 2015

Member

Great! Then this issue should be closed. Looking forward to the release then.

Member

2m commented Jul 27, 2015

Great! Then this issue should be closed. Looking forward to the release then.

@2m

This comment has been minimized.

Show comment
Hide comment
@2m

2m Sep 1, 2015

Member

What can I do to help releasing new version of sbt-git with this fix? This bug really bites new projects when there are no tags yet in the repository.

Member

2m commented Sep 1, 2015

What can I do to help releasing new version of sbt-git with this fix? This bug really bites new projects when there are no tags yet in the repository.

@jsuereth

This comment has been minimized.

Show comment
Hide comment
@jsuereth

jsuereth Sep 1, 2015

Member

@2m If you'd like to cut a release, it should be as easy as tagging a version and pushing to bintray. Do you need credentials to do so? I can give these to you.

Member

jsuereth commented Sep 1, 2015

@2m If you'd like to cut a release, it should be as easy as tagging a version and pushing to bintray. Do you need credentials to do so? I can give these to you.

@2m

This comment has been minimized.

Show comment
Hide comment
@2m

2m Sep 2, 2015

Member

I think I am fine with bintray credentials. But I can not manage github project like closing fixed issues, etc.

Member

2m commented Sep 2, 2015

I think I am fine with bintray credentials. But I can not manage github project like closing fixed issues, etc.

@dwijnand dwijnand closed this Dec 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment