Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java version detection and comparison for JDK 10 #225

Merged
merged 2 commits into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@eed3si9n
Copy link
Member

commented Apr 6, 2018

Fixes sbt/sbt#4055

This fixes number comparison on Bash script, and version detection on Windows batch file.
JDK 10 tests are added on both Travis CI and AppVeyor.

@eed3si9n eed3si9n added the in progress label Apr 6, 2018

eed3si9n added some commits Apr 6, 2018

Fix bash number comparison
This adds JDK 10 and 11 testing on Linux
Fix Java version detection on Windows
Fixes sbt/sbt#4055
Adds JDK 10 testing on Windows

@eed3si9n eed3si9n force-pushed the eed3si9n:wip/jdk10 branch from c93dc99 to b2fdb76 Apr 6, 2018

@eed3si9n eed3si9n changed the title Test using JDK 10 and 11 Fix Java version detection and comparison for JDK 10 Apr 6, 2018

@dwijnand
Copy link
Member

left a comment

nice one

@dwijnand dwijnand merged commit 8350d7c into sbt:master Apr 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n deleted the eed3si9n:wip/jdk10 branch Apr 6, 2018

@Abhi-joshi

This comment has been minimized.

Copy link

commented Apr 15, 2018

@eed3si9n @dwijnand This is still reproducible with 1.1.4 version. See my comment on https://github.com/sbt/sbt/issues/4055

@xuwei-k xuwei-k referenced this pull request May 12, 2018

Closed

Java 10 not recognized #443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.