Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java version detection broken on windows #227

Merged
merged 2 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@spangaer
Copy link
Contributor

commented Apr 10, 2018

  • Java version detection broken, when path to JDK contains spaces.
    Allways outputs:
    sbt requires at least version 6+, you have
    version 0

  • the quoted version word for findstr doesn't seem to work in the for-command statement, quotes not needed for a single word.

- Java version detection broken, when path to JDK contains spaces.
  Allways outputs:
    sbt requires at least version 6+, you have
    version 0

- the quoted version word for findstr doesn't seem to work in the for-command statement, quotes not needed for a single word.

@eed3si9n eed3si9n added the ready label Apr 10, 2018

@dwijnand dwijnand requested a review from eed3si9n Apr 10, 2018

@eed3si9n eed3si9n merged commit 3ff2cc0 into sbt:master Apr 23, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the ready label Apr 23, 2018

@hmemcpy

This comment has been minimized.

Copy link

commented Apr 28, 2018

(disregard previous comment, I didn't launch the correct sbt.bat 😳)
Can confirm this fixes the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.