From 6a10cdda2551e0f70ca51c3344873d8cbe8fd870 Mon Sep 17 00:00:00 2001 From: Alexey Kardapoltsev Date: Fri, 11 Apr 2014 10:48:05 +0600 Subject: [PATCH] wrong permissions for /usr/share/app_name fixed --- .../com/typesafe/sbt/packager/archetypes/JavaApp.scala | 6 +++--- .../sbt/packager/archetypes/JavaServerApplication.scala | 1 - src/sbt-test/debian/daemon-user-deb/build.sbt | 1 + 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala index 44f945da5..91778f6e4 100644 --- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala +++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaApp.scala @@ -64,12 +64,12 @@ object JavaAppPackaging { s <- script.toSeq } yield s -> ("bin/" + name + ".bat") }, - linuxPackageMappings in Debian <+= (normalizedName, defaultLinuxInstallLocation, target in Debian, daemonUser in Linux, daemonGroup in Linux) map { - (name, installLocation, target, user, group) => + linuxPackageMappings in Debian <+= (normalizedName, defaultLinuxInstallLocation, target in Debian) map { + (name, installLocation, target) => // create empty var/log directory val d = target / installLocation d.mkdirs() - LinuxPackageMapping(Seq(d -> (installLocation + "/" + name)), LinuxFileMetaData(user, group)) + LinuxPackageMapping(Seq(d -> (installLocation + "/" + name)), LinuxFileMetaData()) }) def makeRelativeClasspathNames(mappings: Seq[(File, String)]): Seq[String] = diff --git a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala index 09aeb4a10..d8aa328c2 100644 --- a/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala +++ b/src/main/scala/com/typesafe/sbt/packager/archetypes/JavaServerApplication.scala @@ -75,7 +75,6 @@ object JavaServerAppPackaging { makeMaintainerScript(builder.startScript, Some(template))(tmpDir, loader, replacements, builder) }, linuxPackageMappings in Debian <++= (normalizedName, linuxMakeStartScript in Debian, serverLoading in Debian) map startScriptMapping, - // TODO should we specify daemonGroup in configs? // === Maintainer scripts === debianMakePreinstScript <<= (target in Universal, serverLoading in Debian, linuxScriptReplacements, linuxJavaAppStartScriptBuilder in Debian) map makeMaintainerScript(Preinst), diff --git a/src/sbt-test/debian/daemon-user-deb/build.sbt b/src/sbt-test/debian/daemon-user-deb/build.sbt index 779c258f9..5d87f6663 100644 --- a/src/sbt-test/debian/daemon-user-deb/build.sbt +++ b/src/sbt-test/debian/daemon-user-deb/build.sbt @@ -37,6 +37,7 @@ TaskKey[Unit]("check-control-files") <<= (target, streams) map { (target, out) = assert(!(postinst contains "chown debian-test:daemongroup"), "postinst contains wrong user: \n" + postinst) assert(!(postinst contains "chown daemonuser:debian-test"), "postinst contains wrong group: \n" + postinst) assert(!(postinst contains "chown debian-test:debian-test"), "postinst contains wrong user and group: \n" + postinst) + assert(!(postinst contains "chown daemonuser:daemongroup /usr/share/debian-test"), "postinst contains chown /usr/share/app_name: \n" + postinst) out.log.success("Successfully tested upstart control files") () }