Give an absolute path to the entrypoint #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joan38, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
joan38
force-pushed
the
absolute-entrypoint
branch
from
125b300
to
71f5122
Compare
|
All signed |
|
Thanks for your pull request 😃 There are three scripted tests failing
An absolute path makes sense to me, even my docker experience is limited. |
joan38
force-pushed
the
absolute-entrypoint
branch
2 times, most recently
from
ba6f7ea
to
fd41a13
Compare
|
All good now @muuki88 |
muuki88
approved these changes
Feb 16, 2018
|
Awesome, thanks ❤️ |
|
@muuki88 Do you know if that's been released? If no will it be in the next one? |
|
Ah! thanks for pocking me on this. There you go 😍 |
|
Your awesome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes need to change the the WORKDIR, and when we do the ENTRYPOINT becomes invalid.
In general it's good to use absolute paths unless things are sementicaly tied to each other, which is not the case of ENTRYPOINT regarding WORKDIR