New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent loading a project with the wrong version of sbt #1055

Closed
jrudolph opened this Issue Dec 30, 2013 · 3 comments

Comments

Projects
None yet
5 participants
@jrudolph
Member

jrudolph commented Dec 30, 2013

This situation arises if someone tries to use reload after having changed build.properties. As it's probably harder/impossible to fix taking build.properties into account when running reload sbt could at least refuse to load when the sbt.version in build.properties doesn't match the current runtime version.

@harrah

This comment has been minimized.

Show comment
Hide comment
@harrah

harrah Jan 2, 2014

Member

Note that reboot is the command that indicates you want to completely restart sbt and reread build.properties. This throws away pretty much everything, so it shouldn't be run unless it is actually needed. reload could perhaps see if build.properties has changed and run reboot if it did, but I don't know whether that is a good idea.

Member

harrah commented Jan 2, 2014

Note that reboot is the command that indicates you want to completely restart sbt and reread build.properties. This throws away pretty much everything, so it shouldn't be run unless it is actually needed. reload could perhaps see if build.properties has changed and run reboot if it did, but I don't know whether that is a good idea.

@jozic

This comment has been minimized.

Show comment
Hide comment
@jozic

jozic Jan 2, 2014

Contributor

reload could emit a warning if build.properties has changed and recommend to runreboot explicitly

Contributor

jozic commented Jan 2, 2014

reload could emit a warning if build.properties has changed and recommend to runreboot explicitly

@jsuereth

This comment has been minimized.

Show comment
Hide comment
@jsuereth

jsuereth Jan 2, 2014

Member

That seems most reasonable
On Jan 2, 2014 10:57 AM, "Eugene Platonov" notifications@github.com wrote:

reload could emit a warning if build.properties has changed and recommend
to runreboot explicitly


Reply to this email directly or view it on GitHubhttps://github.com//issues/1055#issuecomment-31461382
.

Member

jsuereth commented Jan 2, 2014

That seems most reasonable
On Jan 2, 2014 10:57 AM, "Eugene Platonov" notifications@github.com wrote:

reload could emit a warning if build.properties has changed and recommend
to runreboot explicitly


Reply to this email directly or view it on GitHubhttps://github.com//issues/1055#issuecomment-31461382
.

@jsuereth jsuereth added Bug and removed Bug labels Feb 11, 2014

@Duhemm Duhemm added the Spree label Oct 21, 2017

RomanIakovlev added a commit to RomanIakovlev/sbt that referenced this issue Oct 26, 2017

RomanIakovlev added a commit to RomanIakovlev/sbt that referenced this issue Oct 26, 2017

RomanIakovlev added a commit to RomanIakovlev/sbt that referenced this issue Oct 26, 2017

RomanIakovlev added a commit to RomanIakovlev/sbt that referenced this issue Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment