New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt 1.0.3 not longer watches test classpath #3687

Closed
francisdb opened this Issue Oct 28, 2017 · 16 comments

Comments

Projects
None yet
6 participants
@francisdb

francisdb commented Oct 28, 2017

problem

macOS (have not tried other os)

with sbt 1.0.2 when using ~test:compile and modifying a test the test is recompiled (same with ~testOnly xxx)

with sbt 1.0.3 when using ~test:compile and modifying a test nothing happens (does recompile when changing code in src/main)

could be related to the changes in #3527?

@francisdb

This comment has been minimized.

Show comment
Hide comment
@francisdb

francisdb Oct 29, 2017

hmm, I seem to also see this for some non-test files.

francisdb commented Oct 29, 2017

hmm, I seem to also see this for some non-test files.

@dwijnand dwijnand self-assigned this Oct 30, 2017

@francisdb

This comment has been minimized.

Show comment
Hide comment
@francisdb

francisdb Oct 30, 2017

@dwijnand let me know if you have a hard time reproducing this, then I can try to come up with a test project

francisdb commented Oct 30, 2017

@dwijnand let me know if you have a hard time reproducing this, then I can try to come up with a test project

@dwestheide

This comment has been minimized.

Show comment
Hide comment
@dwestheide

dwestheide Oct 30, 2017

+1 – I am on macOS, and it seems that neither test sources nor main sources are watched, or at least, no triggered task execution is happening any more in SBT 1.0.3.

dwestheide commented Oct 30, 2017

+1 – I am on macOS, and it seems that neither test sources nor main sources are watched, or at least, no triggered task execution is happening any more in SBT 1.0.3.

@ScalaWilliam

This comment has been minimized.

Show comment
Hide comment
@ScalaWilliam

ScalaWilliam Nov 3, 2017

For me ~testQuick didn't work on Linux sometimes - changing a compile classpath source would not trigger any change.

ScalaWilliam commented Nov 3, 2017

For me ~testQuick didn't work on Linux sometimes - changing a compile classpath source would not trigger any change.

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 17, 2017

Member

The upstream issue is sbt/io#82.

Member

dwijnand commented Nov 17, 2017

The upstream issue is sbt/io#82.

@OlegYch

This comment has been minimized.

Show comment
Hide comment
@OlegYch

OlegYch Nov 17, 2017

Contributor

@dwijnand on windows and linux PollingWatchService is not really relevant..

Contributor

OlegYch commented Nov 17, 2017

@dwijnand on windows and linux PollingWatchService is not really relevant..

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 20, 2017

Member

@OlegYch Yeah, there are multiple issues going on at once. But I think the regression tracked here has to do with the solution (shipping as of 1.0.3) being PollingWatchService-based, which is also broken..

Member

dwijnand commented Nov 20, 2017

@OlegYch Yeah, there are multiple issues going on at once. But I think the regression tracked here has to do with the solution (shipping as of 1.0.3) being PollingWatchService-based, which is also broken..

@francisdb

This comment has been minimized.

Show comment
Hide comment
@francisdb

francisdb Nov 29, 2017

I think this can be closed as it's a duplicate of #3695?

francisdb commented Nov 29, 2017

I think this can be closed as it's a duplicate of #3695?

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 29, 2017

Member

The use cases are slightly different. Last I tried I couldn't reproduce #3695, but I could this one. Which, btw, I'm going to investigate more today, with the info in #3775 / sbt/io#86.

Member

dwijnand commented Nov 29, 2017

The use cases are slightly different. Last I tried I couldn't reproduce #3695, but I could this one. Which, btw, I'm going to investigate more today, with the info in #3775 / sbt/io#86.

@francisdb

This comment has been minimized.

Show comment
Hide comment
@francisdb

francisdb Nov 29, 2017

Ah, great to see you are getting tot he root cause of this 👍

francisdb commented Nov 29, 2017

Ah, great to see you are getting tot he root cause of this 👍

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 29, 2017

Member

Real upstream is sbt/io#86.

Member

dwijnand commented Nov 29, 2017

Real upstream is sbt/io#86.

dwijnand added a commit to sbt/io that referenced this issue Nov 29, 2017

dwijnand added a commit to dwijnand/sbt-io that referenced this issue Nov 29, 2017

@OlegYch

This comment has been minimized.

Show comment
Hide comment
@OlegYch

OlegYch Dec 1, 2017

Contributor

modifications to files in dependent projects are also ignored, even if executing the command directly in that project like ~derp/compile
btw it would be nice to add proper toString to classes like sbt.io.SimpleFileFilter and sbt.internal.io.Source, or all sbt classes for that matter, and make their properties public (or make them case classes?), otherwise inspecting much of sbt keys (watchSources in this case) is an exercise in frustration

Contributor

OlegYch commented Dec 1, 2017

modifications to files in dependent projects are also ignored, even if executing the command directly in that project like ~derp/compile
btw it would be nice to add proper toString to classes like sbt.io.SimpleFileFilter and sbt.internal.io.Source, or all sbt classes for that matter, and make their properties public (or make them case classes?), otherwise inspecting much of sbt keys (watchSources in this case) is an exercise in frustration

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Dec 1, 2017

Member

btw it would be nice to add proper toString to classes like sbt.io.SimpleFileFilter and sbt.internal.io.Source, or all sbt classes for that matter, and make their properties public (or make them case classes?), otherwise inspecting much of sbt keys (watchSources in this case) is an exercise in frustration

Done: sbt/io#77

Member

dwijnand commented Dec 1, 2017

btw it would be nice to add proper toString to classes like sbt.io.SimpleFileFilter and sbt.internal.io.Source, or all sbt classes for that matter, and make their properties public (or make them case classes?), otherwise inspecting much of sbt keys (watchSources in this case) is an exercise in frustration

Done: sbt/io#77

@OlegYch

This comment has been minimized.

Show comment
Hide comment
@OlegYch

OlegYch Dec 13, 2017

Contributor

@eed3si9n does this fix the issue on windows (which afaik doesn't use pollingwatchservice) ?

Contributor

OlegYch commented Dec 13, 2017

@eed3si9n does this fix the issue on windows (which afaik doesn't use pollingwatchservice) ?

@dwijnand dwijnand modified the milestones: 1.1.1, 1.1.0 Dec 13, 2017

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Dec 13, 2017

Member

@OlegYch No, that must be another issue. One which I'm not sure has already been reported.

Also, the fix was merged in sbt/io's 1.0.x branch, which I just merged into the 1.1.x branch (sbt/io#99), so that it can be in sbt 1.1.0-RC2. Re-opening so we know to re-release sbt/io for 1.1.0-RC2.

Member

dwijnand commented Dec 13, 2017

@OlegYch No, that must be another issue. One which I'm not sure has already been reported.

Also, the fix was merged in sbt/io's 1.0.x branch, which I just merged into the 1.1.x branch (sbt/io#99), so that it can be in sbt 1.1.0-RC2. Re-opening so we know to re-release sbt/io for 1.1.0-RC2.

@dwijnand dwijnand reopened this Dec 13, 2017

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Dec 16, 2017

Member

New io with the fix was merged in #3816

Member

eed3si9n commented Dec 16, 2017

New io with the fix was merged in #3816

@eed3si9n eed3si9n closed this Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment