Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add the standard main manifest attributes with packageOptions #145

Merged
merged 1 commit into from Aug 8, 2011

Conversation

Projects
None yet
2 participants
Member

indrajitr commented Aug 7, 2011

As followup to #140, this adds the commonly used main attributes to jar manifest by default. One can override packageOptions as usual to modify this.

Other build tools also injects the tool and JVM details in the jar manifest as so.
Ant-Version: Apache Ant 1.8.1 Created-By: 1.5.0_22-b03 (Sun Microsystems Inc.).
I have skipped them as I am not sure about their practicality apart from
cosmetic 'fingerprinting' the jar. I can put them in if Mark opines in favor.

Member

indrajitr commented Aug 8, 2011

Sorry, I didn't get the scope convention right.

Further, I think it makes less sense to apply all the manifest attributes to all kinds of jars. Just having them for binary jars and to an extent source jars should suffice.

@harrah harrah added a commit that referenced this pull request Aug 8, 2011

@harrah harrah Merge pull request #145 from indrajitr/jar-manifests
Add the standard main manifest attributes with packageOptions
db14184

@harrah harrah merged commit db14184 into sbt:0.10 Aug 8, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment