Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bundledLauncherProj to allProj #2057

Merged
merged 5 commits into from Jun 21, 2015
Merged

Adds bundledLauncherProj to allProj #2057

merged 5 commits into from Jun 21, 2015

Conversation

eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Jun 14, 2015

This matters when someone tries to locally build sbt from source.

/review @dwijnand, @jsuereth

@dwijnand
Copy link
Member

@dwijnand dwijnand commented Jun 14, 2015

👍

Everything's used by sbtRoot now:

  • before: before
  • after: after

@eed3si9n
Copy link
Member Author

@eed3si9n eed3si9n commented Jun 14, 2015

@jsuereth There's a legit failure introduced by #1938 (wrapped launcher).
launch directory contains tests, but because autoScalaLibrary is set to false, it's unable to compile the tests.

@jsuereth
Copy link
Member

@jsuereth jsuereth commented Jun 17, 2015

Hmm, so we should remove the tests?

Your PR looks good to me

@eed3si9n
Copy link
Member Author

@eed3si9n eed3si9n commented Jun 17, 2015

Yea. I'll try to split out the test into another subproject.

eed3si9n added a commit that referenced this issue Jun 21, 2015
Adds bundledLauncherProj to allProj
@eed3si9n eed3si9n merged commit 01f1627 into 0.13 Jun 21, 2015
3 checks passed
@eed3si9n eed3si9n deleted the wip/fixbuild branch Jun 21, 2015
eatkins pushed a commit to eatkins/sbt that referenced this issue Dec 8, 2019
Adds bundledLauncherProj to allProj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants