New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggeredBy/storeAs/etc using := #2908

Merged
merged 6 commits into from Jan 13, 2017

Conversation

Projects
None yet
2 participants
@dwijnand
Member

dwijnand commented Jan 13, 2017

Fixes #1444

Fixes .triggeredBy/.storeAs/etc not working when using 0.13 style := and .value DSL:

taskC := (taskC triggeredBy taskD).value

dwijnand added some commits Jan 11, 2017

Copy all attributes for all methods in SingleInTask
For when := is used over <<= for 'triggeredBy', 'runBefore', etc..
Migrate actions/depends-on to fix it
Seems following the deprecation warning info and the website
documentation and avoiding the BuildCommon inputTask method avoids
whatever problem was causing it to fail... Strange.. but ok?

@eed3si9n eed3si9n merged commit 33e7cbc into sbt:0.13 Jan 13, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Jan 13, 2017

@dwijnand dwijnand deleted the dwijnand:fix-triggeredBy branch Jan 13, 2017

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 13, 2017

Member

oh. Release notes plz, and forward port.

Member

eed3si9n commented Jan 13, 2017

oh. Release notes plz, and forward port.

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Feb 6, 2017

Member

Notes in #2952

Member

dwijnand commented Feb 6, 2017

Notes in #2952

@eed3si9n eed3si9n referenced this pull request Apr 4, 2017

Closed

[sbt 1.0] Forward port 0.13 changes #2352

7 of 7 tasks complete

@eed3si9n eed3si9n changed the title from Fix triggeredBy/storeAs/etc using :=. Fixes #1444 to Fix triggeredBy/storeAs/etc using := Apr 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment