New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt client-server port discovery #3556

Merged
merged 7 commits into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@eed3si9n
Member

eed3si9n commented Sep 17, 2017

This implements JSON-based port file. Throughout the lifetime of the sbt server, there will be cwd / "project" / "target" / "active.json", which contains uri field.

{"uri":"tcp://127.0.0.1:5010"}

Using this a potential client, such as IDEs, can find out which port number to hit.

Ref #3508

eed3si9n added some commits Sep 11, 2017

JSON port file
This implements JSON-based port file. Thoughout the lifetime of the sbt server there will be `cwd / "project" / "target" / "active.json"`, which contains `url` field.

Using this `url` the potential client, such as IDEs can find out which port number to hit.

Ref #3508

@eed3si9n eed3si9n added this to the 1.1.0 milestone Sep 17, 2017

@eed3si9n eed3si9n requested a review from dwijnand Sep 17, 2017

@dwijnand dwijnand self-assigned this Sep 21, 2017

@typesafe-tools

This comment has been minimized.

Show comment
Hide comment
@typesafe-tools

typesafe-tools Sep 23, 2017

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt pull/3556/head 252e803
zinc 1.x sbt/zinc@32e106d
io 1.x sbt/io@62004b2
librarymanagement 1.x sbt/librarymanagement@293666f
util 1.x sbt/util@cba6f83
website 1.x

The result is: SUCCESS
(restart)

typesafe-tools commented Sep 23, 2017

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt pull/3556/head 252e803
zinc 1.x sbt/zinc@32e106d
io 1.x sbt/io@62004b2
librarymanagement 1.x sbt/librarymanagement@293666f
util 1.x sbt/util@cba6f83
website 1.x

The result is: SUCCESS
(restart)

Reference token file using URI and full file path
Node didn't seem to like read URI out of the box, and I am not sure if File -> URI -> File conversion is universally accepted.

Ref #3088

@eed3si9n eed3si9n referenced this pull request Sep 25, 2017

Merged

language server protocol (VS Code integration) #3524

4 of 4 tasks complete

@dwijnand dwijnand merged commit 9d8a041 into sbt:1.x Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n deleted the eed3si9n:wip/plain_portfile branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment