New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3564: Filter scripted tests based on project/build.properties #3566

Merged
merged 3 commits into from Sep 26, 2017

Conversation

Projects
None yet
2 participants
@jonas
Member

jonas commented Sep 21, 2017

Skip scripted tests where the binary version configured in the build
does not match the binary version of sbt used for cross-building.

References: #3564
Version against 0.13: https://github.com/jonas/sbt/tree/scripted-skip-0.13

Fix #3564: Filter scripted tests based on project/build.properties
Skip scripted tests where the binary version configured in the build
does not match the binary version of sbt used for cross-building.

@dwijnand dwijnand added this to the 1.1.0 milestone Sep 22, 2017

@dwijnand

Looks great to me. Thanks @jonas. I have 2 requests. 1 is the deprecation version string. The other is could you add some notes, please? See https://github.com/sbt/sbt/blob/1.x/CONTRIBUTING.md#adding-notes. Thank you.

$ copy-file changes/test src/sbt-test/group/skipped/test
# Should fail when run explicitly
-> scripted group/skipped

This comment has been minimized.

@dwijnand

dwijnand Sep 22, 2017

Member

A scripted test running scripted, how meta. I love it 😄

@dwijnand

dwijnand Sep 22, 2017

Member

A scripted test running scripted, how meta. I love it 😄

This comment has been minimized.

@jonas

jonas Sep 25, 2017

Member

Copied from sbt/src/sbt-test/project/scripted-plugin. I had to wrap my head around it a few times to understand what was going on, but I think it makes perfect sense in this case to test with and without the build.properties file.

@jonas

jonas Sep 25, 2017

Member

Copied from sbt/src/sbt-test/project/scripted-plugin. I had to wrap my head around it a few times to understand what was going on, but I think it makes perfect sense in this case to test with and without the build.properties file.

Show outdated Hide outdated scripted/sbt/src/main/scala/sbt/test/ScriptedTests.scala Outdated

@jonas jonas referenced this pull request Sep 23, 2017

Merged

Support paradox for sbt 1.0 #111

@jonas

This comment has been minimized.

Show comment
Hide comment
@jonas

jonas Sep 25, 2017

Member

@dwijnand Fixed the deprecation version and added release notes. Should I create a PR for the 0.13 branch as well?

Member

jonas commented Sep 25, 2017

@dwijnand Fixed the deprecation version and added release notes. Should I create a PR for the 0.13 branch as well?

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Sep 26, 2017

Member

If you'd like this in a 0.13 release then yes - I personally don't mind.

Member

dwijnand commented Sep 26, 2017

If you'd like this in a 0.13 release then yes - I personally don't mind.

@dwijnand dwijnand merged commit 67d1da4 into sbt:1.x Sep 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jonas jonas deleted the jonas:scripted-skip-1.0 branch Sep 26, 2017

@jonas

This comment has been minimized.

Show comment
Hide comment
@jonas

jonas Sep 26, 2017

Member

Hmm, I guess I could just upgrade builds to sbt 1.0. 😁

Member

jonas commented Sep 26, 2017

Hmm, I guess I could just upgrade builds to sbt 1.0. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment