New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape imports from sbt files #3635

Merged
merged 1 commit into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@PanAeon
Contributor

PanAeon commented Oct 12, 2017

Escape imports from sbt files, so if user creates a backquoted definition then task evalution will not fail.
Fixes #3464

@PanAeon PanAeon changed the title from Fixes #3464. Escape imports from sbt files to Escape imports from sbt files Oct 12, 2017

@dwijnand

Nice @PanAeon, thank you!

Could you add a note with reference to the fix please? https://github.com/sbt/sbt/blob/1.x/CONTRIBUTING.md#adding-notes

Also could you add a little scripted test testing the fix, please?

@dwijnand dwijnand added this to the 1.1.0 milestone Oct 12, 2017

Fixes #3464. Escape imports from sbt files, so if user creates a back…
…quoted definition then task evalution will not fail.
@PanAeon

This comment has been minimized.

Show comment
Hide comment
@PanAeon

PanAeon Oct 13, 2017

Contributor

Hi, @dwijnand I have added notes and some scripted tests, could you review the changes?

Contributor

PanAeon commented Oct 13, 2017

Hi, @dwijnand I have added notes and some scripted tests, could you review the changes?

@dwijnand

Looks great, thank you.

@dwijnand dwijnand merged commit 4ce4fb7 into sbt:1.x Oct 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment