New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nameOption to the Command trait #3671

Merged
merged 4 commits into from Nov 3, 2017

Conversation

Projects
None yet
6 participants
@miklos-martin
Contributor

miklos-martin commented Oct 26, 2017

Fixes #3297 and #3531

@eed3si9n eed3si9n added the ready label Oct 26, 2017

Show outdated Hide outdated main-command/src/main/scala/sbt/Command.scala Outdated
Show outdated Hide outdated main-command/src/main/scala/sbt/Command.scala Outdated

@miklos-martin miklos-martin changed the title from Add commandName as an extension method in Command to Add nameOption as an extension method in Command Oct 27, 2017

@dwijnand

LGTM, but I'll hold fire to see about the value class thing..

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Oct 27, 2017

Member

IMHO optionalName is better than nameOption.

Member

jvican commented Oct 27, 2017

IMHO optionalName is better than nameOption.

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Oct 30, 2017

Member

Given nameOption matches reduceOption and headOption in the standard library, I think it might feel more familiar.

Member

dwijnand commented Oct 30, 2017

Given nameOption matches reduceOption and headOption in the standard library, I think it might feel more familiar.

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Oct 30, 2017

Member

Sounds reasonable, then.

Member

jvican commented Oct 30, 2017

Sounds reasonable, then.

@Duhemm Duhemm added the Spree label Oct 30, 2017

@miklos-martin miklos-martin changed the title from Add nameOption as an extension method in Command to Add nameOption to the Command trait Nov 2, 2017

@miklos-martin

This comment has been minimized.

Show comment
Hide comment
@miklos-martin

miklos-martin Nov 2, 2017

Contributor

my pleasure

Contributor

miklos-martin commented Nov 2, 2017

my pleasure

miklos-martin added some commits Oct 26, 2017

Fixes #3297 and #3531
Add commandName as an extension method in Command
@miklos-martin

This comment has been minimized.

Show comment
Hide comment
@miklos-martin

miklos-martin Nov 3, 2017

Contributor

I've rebased this

Contributor

miklos-martin commented Nov 3, 2017

I've rebased this

@dwijnand dwijnand added this to the 1.1.0 milestone Nov 3, 2017

@dwijnand dwijnand merged commit 9232a8f into sbt:1.x Nov 3, 2017

2 checks passed

codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment