Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new setting to determine if running in CI env #3672
The changes LGTM, but I'm wondering if there's a risk of people having troubles with timeouts in Travis (and potentially other CIs) because no output may be produced for a relatively long time. Can people remove the
CI environment variable when running outside of self-hosted CIs? I would suggest to:
CIis defined, log a line saying that logging can be explicitly enabled by setting an environment variable
- Check if that environment variable is set, and if so, still log the resolving information.
@jvican What do you think?
@Duhemm regarding your concern about timeouts because of no output produced, if I understood it correctly. I just wanted to point this PR doesn't change the actual behavior of sbt, because the code to check the environment variables in