New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not always use Level.Debug while creating a backgroundLog #3717

Merged
merged 1 commit into from Nov 6, 2017

Conversation

Projects
None yet
3 participants
@cunei
Contributor

cunei commented Nov 6, 2017

The creation of a backgroundLog was always using Debug as the
logging level for console and backing. This commit sets the
levels to those used by the caller. Fixes #3655

Do not always use Level.Debug while creating a backgroundLog
The creation of a backgroundLog was always using Debug as the
logging level for console and backing. This commit sets the
levels to those used by the caller. Fixes #3655

@cunei cunei requested a review from eed3si9n Nov 6, 2017

@eed3si9n eed3si9n added the in progress label Nov 6, 2017

@cunei cunei changed the base branch from 1.0.x to 1.x Nov 6, 2017

@dwijnand dwijnand changed the base branch from 1.x to 1.0.x Nov 6, 2017

@dwijnand dwijnand changed the base branch from 1.0.x to 1.x Nov 6, 2017

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 6, 2017

Member

@cunei Could you rebase this branch on 1.0.x so we can merge it there? That way we can ship this in 1.0.4.

Member

dwijnand commented Nov 6, 2017

@cunei Could you rebase this branch on 1.0.x so we can merge it there? That way we can ship this in 1.0.4.

@dwijnand

Looks reasonable to me, but we need to rebase this to merge it for 1.0.4.

@cunei cunei changed the base branch from 1.x to 1.0.x Nov 6, 2017

@cunei

This comment has been minimized.

Show comment
Hide comment
@cunei

cunei Nov 6, 2017

Contributor

Rebased on 1.0.x

Contributor

cunei commented Nov 6, 2017

Rebased on 1.0.x

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 6, 2017

Member

Looks good.

Member

eed3si9n commented Nov 6, 2017

Looks good.

@eed3si9n eed3si9n merged commit ee4dcee into sbt:1.0.x Nov 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment