New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3591. "Not a valid key: console-quick" #3762

Merged
merged 1 commit into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@xuwei-k
Member

xuwei-k commented Nov 23, 2017

No description provided.

@dwijnand

Thanks @xuwei-k. I'll leave it unmerged in case @eed3si9n wants to rebase this onto 1.0.x (for 1.0.4).

@dwijnand dwijnand requested a review from eed3si9n Nov 23, 2017

@dwijnand dwijnand added this to the 1.1.0 milestone Nov 23, 2017

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Nov 23, 2017

Member

Actually, I'll assume (given how aware you are about things in the community/GitHub) that you don't need this in 1.0.4 and are happy to wait for 1.1 (which should go RC1 next week), so I'll just merge this as is into 1.x.

Member

dwijnand commented Nov 23, 2017

Actually, I'll assume (given how aware you are about things in the community/GitHub) that you don't need this in 1.0.4 and are happy to wait for 1.1 (which should go RC1 next week), so I'll just merge this as is into 1.x.

@dwijnand dwijnand merged commit 97a2fe8 into sbt:1.x Nov 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codacy/pr Good work! A positive pull request.
Details

@dwijnand dwijnand removed the in progress label Nov 23, 2017

@xuwei-k xuwei-k deleted the xuwei-k:fix-screpl branch Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment