Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode POSIX file path to URI using u3 (file:///) #3805

Merged
merged 2 commits into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@eed3si9n
Copy link
Member

commented Dec 11, 2017

Ref sbt/io#96
Fixes #3801

Under RFC 8089, both u1 and u3 are legal, but many of the other platforms expect traditional u3.
This will increase the compatibility/usability of sbt server, for example to integrate with Vim.

@eed3si9n eed3si9n requested a review from dwijnand Dec 11, 2017

@typesafe-tools

This comment has been minimized.

Copy link

commented Dec 11, 2017

The validator has checked the following projects against Scala 2.12,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt pull/3805/head aeeec48
zinc 1.x sbt/zinc@366eaff
io pull/96/head sbt/io@c803193
librarymanagement 1.x sbt/librarymanagement@858f918
util 1.x sbt/util@83f8eab
website 1.x

The result is: SUCCESS
(restart)

@dwijnand

This comment has been minimized.

Copy link
Member

commented Dec 11, 2017

[info] [error] java.lang.AssertionError: assertion failed: Wrong sbt version: 1.1.0-SNAPSHOT

@dwijnand dwijnand force-pushed the eed3si9n:wip/file_uri branch from aeeec48 to 18e346e Dec 12, 2017

dwijnand and others added some commits Dec 12, 2017

Update version to 1.1.0-SNAPSHOT
.. & fix project/cross-plugins-defaults.
Encode POSIX file path to URI using u3 (file:///)
Ref sbt/io#96

Under RFC 8089, both u1 and u3 are legal, but many of the other platforms expect traditional u3.
This will increase the compatibility/usability of sbt server, for example to integrate with Vim.

@dwijnand dwijnand force-pushed the eed3si9n:wip/file_uri branch from 18e346e to 06b8591 Dec 12, 2017

@dwijnand dwijnand merged commit 2e5aabb into sbt:1.1.x Dec 12, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the in progress label Dec 12, 2017

@eed3si9n eed3si9n deleted the eed3si9n:wip/file_uri branch Dec 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.