Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CaffeineCache a lazy val #3814

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@dwijnand
Copy link
Member

commented Dec 15, 2017

This is to avoid it initialising Log4J2 (via SLF4J), which we initialise
ourselves programmatically in LogExchange. Also there's no need to
removeAll in initialState.

Fixes #3787

My proposed alternative to #3808.

Make CaffeineCache a lazy val
This is to avoid it initialising Log4J2 (via SLF4J), which we initialise
ourselves programmatically in LogExchange. Also there's no need to
removeAll in initialState.

Fixes #3787

@dwijnand dwijnand requested a review from eed3si9n Dec 15, 2017

@dwijnand

This comment has been minimized.

Copy link
Member Author

commented Dec 15, 2017

Forgot to mention: I tested this locally and it removes the "ERROR" warning.

@eed3si9n eed3si9n merged commit 487d94d into sbt:1.1.x Dec 15, 2017

2 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Dec 15, 2017

@dwijnand dwijnand deleted the dwijnand:avoid-log4j2-error-warning branch Dec 15, 2017

@dwijnand dwijnand added this to the 1.1.0 milestone Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.