Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab completion running `sbt console` #3876

Merged
merged 2 commits into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@eed3si9n
Copy link
Member

commented Jan 13, 2018

Fixes #3841

This fixes console task that internally uses JLine. When console is started from batch mode, the tab is printed as is. This is because JLine is not initialized yet.
Calling usingTerminal initializes and restores the terminal afterwards.

@eed3si9n eed3si9n requested a review from dwijnand Jan 13, 2018

@dwijnand
Copy link
Member

left a comment

Nice.

Notes?

Fix tab completion running `sbt console`
Fixes #3841

This fixes console task that internally uses JLine. When `console` is started from batch mode, the tab is printed as is. This is because JLine is not initialized yet.
Calling `usingTerminal` initializes and restores the terminal afterwards.

@eed3si9n eed3si9n force-pushed the eed3si9n:wip/jlineinit branch from c08d182 to ca712ac Jan 16, 2018

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2018

Added notes in ca712ac.

@eed3si9n eed3si9n merged commit 5d89795 into sbt:1.1.x Jan 22, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n deleted the eed3si9n:wip/jlineinit branch Jan 22, 2018

@eed3si9n eed3si9n added this to the 1.1.1 milestone Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.