New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parallel execution of scripted in the plugin #3891

Merged
merged 2 commits into from Jan 19, 2018

Conversation

Projects
None yet
5 participants
@allanrenucci
Contributor

allanrenucci commented Jan 17, 2018

Rebased #3657 from @jvican

@lightbend-cla-validator

This comment has been minimized.

lightbend-cla-validator commented Jan 17, 2018

Hi @allanrenucci,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@eed3si9n eed3si9n added the ready label Jan 17, 2018

jvican and others added some commits Oct 20, 2017

Enable parallel execution of scripted in the plugin
The change to enable batched and parallel execution for scripted was
done only for the scripted-sbt project. This pull request enables it for
scripted-plugin, so that all sbt plugins in 1.x. can benefit from it.

By default, it configures a number of parallel instances of 1 and batch
execution is disabled. Users can change the number of parallel sbt hosts
running scripted tests via the `scriptedParallelInstances` setting.

In some plugins scripted tests', batch execution can cause issues
because the first time `>` commands are executed they assume sbt starts
up. This error can be fixed by doing `reload` before running the `>`
command.

Note that the current scripted plugin does not allow parallel execution
in non-batched mode.
@allanrenucci

This comment has been minimized.

Contributor

allanrenucci commented Jan 19, 2018

I have signed the CLA. Is there any chance this will get in 1.1.1?

@dwijnand

This comment has been minimized.

Member

dwijnand commented Jan 19, 2018

Not sure. It's debatable/borderline. I'm fairly certain this cannot introduce regressions. But it's definitely a feature (or an enhancement).

Either way I've restarted AppVeyor again.

@eed3si9n eed3si9n merged commit 8cfec5b into sbt:1.x Jan 19, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the ready label Jan 19, 2018

@allanrenucci allanrenucci deleted the allanrenucci:scripted branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment