New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the eviction warnings options to global #3947

Merged
merged 3 commits into from Mar 8, 2018

Conversation

Projects
None yet
3 participants
@exoego
Contributor

exoego commented Feb 15, 2018

Partially adresses #3773

It adds the eviction warning options to global, so that one can change the options for all sub projects at a time.

Another PR (adding EvictionWarningsOptions.summary) for the issue in librarymanagement is sbt/librarymanagement#211

@eed3si9n eed3si9n added the ready label Feb 15, 2018

@@ -1999,6 +1999,7 @@ object Classpaths {
ConflictWarning(conflictWarning.value, report, log)
report
},
evictionWarningOptions in update := (evictionWarningOptions in GlobalScope).value,

This comment has been minimized.

@eed3si9n

eed3si9n Mar 7, 2018

Member

RHS should be evictionWarningOptions.value,

This comment has been minimized.

@exoego

exoego Mar 7, 2018

Contributor

Done in dc4f93a

@eed3si9n

LGTM pending Travis

@eed3si9n eed3si9n merged commit ec93e3e into sbt:1.x Mar 8, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the ready label Mar 8, 2018

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 8, 2018

@exoego exoego deleted the exoego:global-eviction-warning-options branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment