Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete buildinfo.BuildInfo from sbt main #3967

Merged
merged 5 commits into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@dwijnand
Copy link
Member

commented Feb 23, 2018

No description provided.

xuwei-k and others added some commits Dec 26, 2017

delete buildinfo.BuildInfo from sbt main
sbt-buildinfo plugin have `buildInfoScopedSettings(Compile)` in default.
I think it is unnecessary. or we should set "buildinfoPackage in Compile" and "buildinfoObject in Compile"

https://github.com/sbt/sbt-buildinfo/blob/v0.7.0/src/main/scala/sbtbuildinfo/BuildInfoPlugin.scala#L11

@dwijnand dwijnand requested a review from eed3si9n Feb 23, 2018

@eed3si9n eed3si9n merged commit 083dd8c into sbt:1.1.x Feb 28, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Feb 28, 2018

@dwijnand dwijnand deleted the dwijnand:buildinfo branch Feb 28, 2018

@eed3si9n eed3si9n changed the title Upgrade to sbt-buildinfo 0.8.0 Delete buildinfo.BuildInfo from sbt main Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.