Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java's redirectInput rather than sys.process's connectInput #3970

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
3 participants
@retronym
Copy link
Member

commented Feb 26, 2018

Fixes #3737

@dwijnand
Copy link
Member

left a comment

ok

@dwijnand dwijnand added this to the 1.1.2 milestone Feb 26, 2018

@eed3si9n
Copy link
Member

left a comment

Thanks!

@eed3si9n eed3si9n merged commit 27bbde8 into sbt:1.1.x Feb 28, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Feb 28, 2018

case out: BufferedOutput => out.logger.buffer { process.run(out.logger, connectInput) }
case out: LoggedOutput => process.run(out.logger, connectInput)
case out: CustomOutput => (process #> out.output).run(connectInput)
case StdoutOutput => process.run(connectInput = false)

This comment has been minimized.

Copy link
@retronym

retronym Feb 28, 2018

Author Member

I should note that my testing in the context of the Scala build was through this code path (outputStrategy = StdoutOutput). I think the way the output is redirected should not have a bearing on how connectInput works, but if you can think of any other use cases to test for, I'd suggest doing some manual testing of this before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.