New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter incompatible aggregates in cross switch commands #3995

Merged
merged 1 commit into from Mar 8, 2018

Conversation

Projects
None yet
4 participants
@ruippeixotog
Contributor

ruippeixotog commented Mar 7, 2018

Fixes #3698.

@eed3si9n eed3si9n added the ready label Mar 7, 2018

@ruippeixotog

This comment has been minimized.

Contributor

ruippeixotog commented Mar 7, 2018

Review by @eed3si9n

@eed3si9n

LGTM

@dwijnand

thanks @ruippeixotog!

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 8, 2018

@dwijnand dwijnand merged commit 80d342a into sbt:1.x Mar 8, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Mar 8, 2018

@ruippeixotog ruippeixotog deleted the ruippeixotog:cross-strict-aggregation branch Mar 8, 2018

@alexflav23

This comment has been minimized.

alexflav23 commented Apr 15, 2018

@eed3si9n @dwijnand Would be nice to see an intermediary release if at all possible with this enabled. It's currently preventing me from upgrading anything to SBT 1.x +, unfortunately almost every single project I deal with is a multi aggregate behemoth with complex versioning rules and binary incompatibilities.

Is there anything I could do to help with an intermediary release from the 1.2.0 milestone you have already planned this for ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment