New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lastGrep command #4080

Merged
merged 1 commit into from Apr 9, 2018

Conversation

Projects
None yet
3 participants
@naferx
Contributor

naferx commented Apr 8, 2018

Ref #4072

@eed3si9n eed3si9n added the ready label Apr 8, 2018

@eed3si9n

LGTM

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Apr 8, 2018

Thanks for this contribution.
I opened a new issue #4081 for other commands, if you're up for it.

@dwijnand dwijnand added this to the 1.2.0 milestone Apr 9, 2018

@dwijnand dwijnand merged commit 6718803 into sbt:1.x Apr 9, 2018

3 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Apr 9, 2018

@naferx

This comment has been minimized.

Contributor

naferx commented Apr 9, 2018

@eed3si9n Yeah, I'd like to keep contributing, Thanks!
I was wondering how to inform to the user that the command is being deprecated
I have in mind two alternatives:

  • Include it in the (old) detailed message
  • When the user types the (old) command it raises a warning log

@naferx naferx deleted the naferx:add-lastGrep branch Apr 9, 2018

@dwijnand

This comment has been minimized.

Member

dwijnand commented Apr 9, 2018

When the user types the (old) command it raises a warning log

that would be the more important effect, to me. I don't think there's a built in way to do this in sbt's commands.

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Apr 9, 2018

Could we output log with warning level or something?

@naferx

This comment has been minimized.

Contributor

naferx commented Apr 10, 2018

I'll give it a try over the next days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment