WIP: Fix unexpected responses from the server #4093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4091.
85ab082 should fix the first problem.
And I think the second one sits here:
sbt/main/src/main/scala/sbt/internal/CommandExchange.scala
Lines 250 to 256 in 7ae83cc
But I'm not sure how to fix it. In this case it matches any events (so we cannot check channel name here) and redirects them to the
NetworkChannel.publishEvent
which already doesn't check if the channel name matches.On the other hand there is also
publishEventMessage
method which handlesExecStatusEvent
and checks channel name. So probably we could reuse it here.I'm not sure what is the general intent of this piece of code quoted above: if it's not a
StringMessage
, just broadcast is on all channels? Even if we want to do that,publishEvent
is not a good choice, probably usinglangNotify
or something similar would be better.