Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude directories instead of including files #4098

Merged
merged 1 commit into from Apr 23, 2018

Conversation

Projects
None yet
4 participants
@eatkins
Copy link
Contributor

commented Apr 13, 2018

The existing filter caused SourceModificationWatch.watch to ignore
deleted files because !file.exists implies !file.isFile. The intention
of the filter was to exclude directories that had a name ending in
".scala".

(See the guidelines for contributing, linked above)

Ethan Atkins
Exclude directories instead of including files
The existing filter caused SourceModificationWatch.watch to ignore
deleted files because !file.exists implies !file.isFile. The intention
of the filter was to exclude directories that had a name ending in
".scala".

@eed3si9n eed3si9n added the ready label Apr 13, 2018

@eatkins

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2018

This should fix #3845

@dwijnand
Copy link
Member

left a comment

nice! thank you!

@dwijnand dwijnand added this to the 1.1.5 milestone Apr 23, 2018

@dwijnand dwijnand merged commit a2af3bf into sbt:1.1.x Apr 23, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Apr 23, 2018

@jrudolph

This comment has been minimized.

Copy link
Member

commented Sep 3, 2018

It seems this broke triggered execution for twirl: playframework/twirl#186

@eatkins eatkins deleted the eatkins:filter branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.