New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch inThisBuild (+friends) to use varargs SettingsDefinition #4106

Merged
merged 2 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@dwijnand
Member

dwijnand commented Apr 19, 2018

No description provided.

@dwijnand dwijnand requested a review from eed3si9n Apr 19, 2018

@dwijnand dwijnand added this to the 1.2.0 milestone Apr 19, 2018

@eed3si9n

Yes.

@dwijnand

This comment has been minimized.

Member

dwijnand commented Apr 19, 2018

I thought there was an issue for this (I thought by @fommil). but I can't find it.

@fommil

This comment has been minimized.

fommil commented Apr 19, 2018

dwijnand added some commits Apr 19, 2018

@dwijnand dwijnand changed the title from Introduce inThisBuild (+friends) varargs overloads to Switch inThisBuild (+friends) to use varargs SettingsDefinition Apr 19, 2018

@dwijnand dwijnand merged commit 187c50c into sbt:1.x Apr 20, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand deleted the dwijnand:overload-varargs-sorta branch Apr 20, 2018

@dwijnand dwijnand removed the in progress label Apr 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment