New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated commands -, --, and --- #4124

Merged
merged 2 commits into from Apr 26, 2018

Conversation

Projects
None yet
3 participants
@eed3si9n
Member

eed3si9n commented Apr 26, 2018

86ae3c8 deprecated -, --, and ---.
This removes the deprecated commands.

Remove deprecated commands -, --, and ---
86ae3c8 deprecated -, --, and ---.
This removes the deprecated commands.

@eed3si9n eed3si9n requested review from dwijnand and cunei Apr 26, 2018

@Duhemm

Any reason to keep def compatCommands (l.155)?

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Apr 26, 2018

I probably could remove it.

@dwijnand
  • dropped compatCommands
  • dropped the whole Compat object
  • MiMa'd them
  • added a reference to the issue

LGTM. Merge (or squash & merge) when

@dwijnand dwijnand added this to the 1.2.0 milestone Apr 26, 2018

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Apr 26, 2018

Thanks @dwijnand :)

@eed3si9n eed3si9n merged commit 812da7a into sbt:1.x Apr 26, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Apr 26, 2018

@eed3si9n eed3si9n deleted the eed3si9n:wip/remove-deprecated branch Apr 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment