Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Scala 2.12.4 -> 2.12.6 #4129

Merged
merged 2 commits into from Apr 30, 2018

Conversation

Projects
None yet
3 participants
@eed3si9n
Copy link
Member

commented Apr 28, 2018

This is a continuation of #4126

RunFromSourceMain currently assumes that Scala is already available in boot directory, which doesn't work if we tried to upgrade to another Scala version. This adds a workaround by letting Ivy resolve it like Launcher does internally.

upgrade Scala 2.12.4 -> 2.12.6
I have no specific user-visible benefit in mind other than fewer
JARs to download for people who are on current versions of things

@eed3si9n eed3si9n requested review from dwijnand and cunei Apr 28, 2018

resolve Scala compiler using Ivy
When Scala compiler is not found in the boot directory, use Ivy to resolve it.

@eed3si9n eed3si9n force-pushed the eed3si9n:wip/bump-scala-to-2.12.6 branch from ea64540 to ccd03ee Apr 28, 2018

@dwijnand
Copy link
Member

left a comment

LGTM. Cool.

@dwijnand dwijnand merged commit d76a138 into sbt:1.1.x Apr 30, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the in progress label Apr 30, 2018

@dwijnand dwijnand added this to the 1.1.5 milestone Apr 30, 2018

@eed3si9n eed3si9n deleted the eed3si9n:wip/bump-scala-to-2.12.6 branch May 9, 2018

tanishiking added a commit to tanishiking/website that referenced this pull request May 25, 2018

Update scala_version to 2.12.6
For sbt1.1.5, scala version is 2.12.6
sbt/sbt#4129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.