Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start sbt in VS Code terminal window #4130

Merged
merged 2 commits into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@eed3si9n
Copy link
Member

commented Apr 29, 2018

Fixes #3624

Previously VS Code extension for sbt required sbt session to be running already. I got a patch from @olofwalker over Slack that opens sbt in VS Code's terminal window, which is more natural.
It seems to work when I tested it locally.

eed3si9n and others added some commits Apr 27, 2018

@eed3si9n

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2018

We can tweak this further, but I am inclined to merge this and get a new version of VS Code extension out, partially because #4128 contains vulnerability fix.

@eed3si9n eed3si9n changed the base branch from 1.1.x to 1.x Apr 29, 2018

@eed3si9n eed3si9n changed the base branch from 1.x to 1.1.x Apr 29, 2018

@eed3si9n eed3si9n merged commit df0a3c2 into sbt:1.1.x Apr 29, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n deleted the eed3si9n:wip/vscode branch Apr 29, 2018

@eed3si9n eed3si9n removed the in progress label Apr 29, 2018

@dwijnand dwijnand added this to the 1.1.5 milestone Apr 30, 2018

eed3si9n added a commit to eed3si9n/sbt that referenced this pull request May 1, 2018

Fix VS Code extension startup
The change contributed in sbt#4130 to start sbt within VS Code looked ok at first, but when I published the extension and started using it, I realized that it's a bit broken.
Basically there's no cleanup logic (that I could find), so simply closing VS Code would leave `project/target/active.json` behind, which lets VS Code extension to attempt connection, and it fails because there's no server running. To workaround this, I'll attempt to connect to the socket to confirm sbt server is up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.