Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated last command strings to camelCase #4159

Merged
merged 1 commit into from May 15, 2018

Conversation

Projects
None yet
3 participants
@Asamsig
Copy link
Contributor

Asamsig commented May 15, 2018

Fixes issues #4081

Removed Load and LoadCommand since they are no longer in use.
Changed add-defaults-commands directly since it is only used internally.
Added deprecation warning for LoadFailed and LastGrep.

@dwijnand dwijnand added this to the 1.2.0 milestone May 15, 2018

@dwijnand
Copy link
Member

dwijnand left a comment

Looks perfect! Thank you and congratulations on your first contribution to sbt!

@dwijnand dwijnand merged commit aabb6a1 into sbt:1.x May 15, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
def oldLoadFailed: Command =
Command(OldLoadFailed) { s =>
s.log.warn(
deprecationWarningText(OldLoadFailed, LoadFailed)

This comment has been minimized.

@eed3si9n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.