New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort and indent plugins output in "about" command #4187

Merged
merged 2 commits into from Jun 13, 2018

Conversation

Projects
None yet
4 participants
@mcanlas
Contributor

mcanlas commented Jun 8, 2018

(I wasn't sure about how to include changelog or "notes" per the guidelines. What release version would a contributor target?)


The output for the about command can be difficult to read, especially if there are many plugins installed.

Available Plugins: sbt.plugins.IvyPlugin, sbt.plugins.JvmPlugin, sbt.plugins.CorePlugin, sbt.plugins.JUnitXmlReportPlugin, sbt.plugins.Giter8TemplatePlugin, com.timushev.sbt.updates.UpdatesPlugin, scoverage.ScoverageSbtPlugin, sbtrelease.ReleasePlugin

This PR changes the output of that section by sorting and indenting the list of plugins.

[info] Available Plugins
[info]  - com.timushev.sbt.updates.UpdatesPlugin
[info]  - sbt.plugins.CorePlugin
[info]  - sbt.plugins.Giter8TemplatePlugin
[info]  - sbt.plugins.IvyPlugin
[info]  - sbt.plugins.JUnitXmlReportPlugin
[info]  - sbt.plugins.JvmPlugin
[info]  - sbtrelease.ReleasePlugin
[info]  - scoverage.ScoverageSbtPlugin
@eed3si9n

Nice. Thanks for the contribution!
I am going to retarget this to 1.x branch.

@eed3si9n eed3si9n changed the base branch from 1.1.x to 1.x Jun 13, 2018

@eed3si9n eed3si9n merged commit ca6115d into sbt:1.x Jun 13, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mcanlas mcanlas deleted the mcanlas:sort-and-indent-plugins-output branch Jun 13, 2018

@2m

This comment has been minimized.

Member

2m commented Jun 14, 2018

Ooh. Good stuff. Thank you, @mcanlas!

@dwijnand

This comment has been minimized.

Member

dwijnand commented Jun 19, 2018

Very cool @mcanlas!

@dwijnand dwijnand added this to the 1.2.0 milestone Jun 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment