New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #4191 (active.json should be removed on JVM shutdown) #4194

Merged
merged 1 commit into from Jun 13, 2018

Conversation

Projects
None yet
2 participants
@veera83372
Member

veera83372 commented Jun 12, 2018

Fixes #4191

Added a shutdown hook to clean up active.json file
Fix for #4191 (active.json should be removed on JVM shutdown)
    Added a shutdown hook to clean up active.json file
@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Jun 13, 2018

@veera83372 Thanks for the contribution!

I've confirmed the behavior locally.

before

sbt:Hello> % # I am typing Ctrl+C
[Ga:/tmp/foobuild/scala-seed-project]$ ls project/target/active.json
project/target/active.json

after

sbt:Hello> %
[Ga:/tmp/foobuild/scala-seed-project]$ ls project/target/active.json
ls: project/target/active.json: No such file or directory

and I've also confirmed that this works when I close VS Code too.

@eed3si9n eed3si9n merged commit 51ee6fc into sbt:1.1.x Jun 13, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@veera83372 veera83372 deleted the veera83372:1.1.x branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment